cmd/fix

go fix incorrectly modifies multi-line embedded struct literals in Go 1.27

#81623 opened 1 month ago by longlonggo

errorsastype rewrites errors.As target interface that does not implement error [1.27 backport]CherryPickApprovedTools

#81389 opened 1 month ago by gopherbot

slicesbackward fails on nested loops

#81170 opened 1 month ago by duncanharris

slicesbackward does not respect keywords

#81169 opened 1 month ago by duncanharris

embedlit: comma in a comment produces invalid code [1.27 backport]BackportCherryPickApproved

#81101 opened 1 month ago by gopherbot

embedlit: comma in a comment produces invalid code [1.26 backport]

#81100 opened 1 month ago by gopherbot

embedlit: comma in a comment produces invalid codeNeedsFix

#81086 opened 2 months ago by nnnkkk7

embedlit: moving field assignments produces duplicate field name in struct literal [1.27 backport]BackportCherryPickApproved

#81059 opened 2 months ago by gopherbot

embedlit: moving field assignments produces duplicate field name in struct literal [1.26 backport]

#81058 opened 2 months ago by gopherbot

embedlit: moving field assignments produces duplicate field name in struct literalBackport

#81055 opened 2 months ago by nnnkkk7

embedlit: drops first field incorrectlyTools

#80993 opened 2 months ago by stevenh

testingcontext fix is not safe when there are deferred functionsAnalysisNeedsFix

#80989 opened 2 months ago by ianlancetaylor

removes all import commentsNeedsInvestigation

#80789 opened 2 months ago by robpike

stringscut rewrites compound strings.Index(...) == -1 short-var-decl into non-compiling code (duplicate found variable)

#80474 opened 3 months ago by Chester13

errorsastype rewrites errors.As target interface that does not implement errorNeedsFixTools

#80031 opened 4 months ago by aethiopicuschan

newexpr and slicescontains analyzers produce uncompilable code when applied together

#79493 opened 5 months ago by AllenWangxiao

x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect count [1.26 backport]CherryPickApproved

#79349 opened 5 months ago by gopherbot

introduced spurious io/fs importBugReport

#79164 opened 5 months ago by bobg

fix inline does not apply to types in func signaturesBugReport

#78994 opened 5 months ago by rsc

wrong `slices.Contains` replacementBugReport

#78993 opened 5 months ago by jcmfernandes

backwardloop makes incorrect fix in some situationsBugReport

#78868 opened 6 months ago by csilvers

stringscut fix causes "assignment mismatch" errorBugReportNeedsInvestigation

#78643 opened 6 months ago by fengttt

fails to make progress after printing "applied 3 of 4 fixes; 1 file updated. (Re-run the command to apply more.)"BugReportFixPendingRefactoring

#78493 opened 6 months ago by oktalz

stringsbuilder breaks code on self-referencing codeBugReportNeedsInvestigation

#78465 opened 6 months ago by csilvers

reflecttypefor replaced TypeOf(f) with TypeFor[func(...)](), losing relationship with symbol fBugReportFixPendingRefactoringokay-after-rc2release-blocker

#78452 opened 6 months ago by MichaelUrman

mapsloop analyzer emits = instead of := in maps.Collect pathBugReportRefactoring

#78322 opened 7 months ago by ryangreenberg

stringscut can result in redundant variable assignment in some casesAnalysisNeedsInvestigationRefactoring

#78207 opened 7 months ago by usmonster

go fix inlining does not inline with new

#78197 opened 7 months ago by alan-anzenna

go fix duplicates `//go:fix inline` lineBugReportNeedsFixRefactoring

#78196 opened 7 months ago by alan-anzenna

panics with "package path has no import prefix" [1.26 backport]CherryPickApproved

#78191 opened 7 months ago by gopherbot

slicescontains: incorrect fix deletes statements, breaks compilationAnalysisBugReport

#78149 opened 7 months ago by david-pejtersen-md

`go fix` adds unnecessary parentheses to typesBugReport

#78088 opened 7 months ago by RTann

modernizer for direct references to embedded fields in struct literalsFeatureRequestFixPendingToolsgoplsrelease-blocker

#77965 opened 7 months ago by madelinekalil

-diff produces interleaved -/+ lines instead of grouped hunks

#77957 opened 7 months ago by oeguchi

bad rangeint rewriting [1.26 backport]CherryPickApprovedTools

#77899 opened 7 months ago by gopherbot

stringscut rewrite changes behavior [1.26 backport]CherryPickApproved

#77849 opened 7 months ago by gopherbot

panics with "package path has no import prefix"BugReportNeedsFix

#77844 opened 7 months ago by mvdan

panic with out of rangeBugReport

#77817 opened 7 months ago by romaindoumenc

stringsbuilder ignores variables if they are used multiple times [1.26 backport]CherryPickApproved

#77807 opened 8 months ago by gopherbot

waitgroup leads to a compilation error [1.26 backport]CherryPickApproved

#77805 opened 8 months ago by gopherbot

minmax breaks select statements [1.26 backport]CherryPickApproved

#77804 opened 8 months ago by gopherbot

reflect.TypeOf(nil) transformed into reflect.TypeFor[untyped nil]() [1.26 backport]CherryPickApproved

#77803 opened 8 months ago by gopherbot

change -diff to exit 1 if diffs exist [1.26 backport]CherryPickApprovedGoCommand

#77801 opened 8 months ago by gopherbot

fix can print "applied 8 of 10 fixes; 2 files updated" and fail without actually applying any fixes [1.26 backport]WaitingForInfo

#77800 opened 8 months ago by gopherbot

stringcut "foreshadows" an existing "ok" varFixPending

#77770 opened 8 months ago by canning-duck

rangeint uses target platform's type in the range expression, breaking other platforms [1.26 backport]CherryPickApproved

#77766 opened 8 months ago by gopherbot

waitgroup leads to a compilation errorBugReportNeedsFixTools

#77754 opened 8 months ago by zhuchkovdev

'go fix -inline .' says 'applied 2 of 3 fixes' but actually applies noneBugReportNeedsInvestigation

#77750 opened 8 months ago by maxb

stringscut rewrite changes behaviorBugReportFixPending

#77737 opened 8 months ago by stapelberg

rangeint uses target platform's type in the range expression, breaking other platformsBugReportNeedsFixTools

#77691 opened 8 months ago by dagood

the `-any` flag and its documentation are misleadingBugReportDocumentationNeedsDecision

#77679 opened 8 months ago by zapateo

slicescontains produces confusing code: if slices.ContainsFunc(s, justForEffects) {}BugReportNeedsInvestigation

#77677 opened 8 months ago by fasaxc

minmax breaks select statementsBugReportNeedsFix

#77671 opened 8 months ago by canning-duck

go tool fix reported as go tool vetBugReportFixPending

#77669 opened 8 months ago by ncw

stringsbuilder ignores variables if they are used multiple timesBugReportNeedsFix

#77659 opened 8 months ago by ccmtaylor

reflect.TypeOf(nil) transformed into reflect.TypeFor[untyped nil]()BugReportNeedsFix

#77636 opened 8 months ago by oeguchi

stringsbuilder breaks code when combining two `strings.Builder`s [1.26 backport]CherryPickApprovedTools

#77624 opened 8 months ago by gopherbot

go fix failing with non zero exit codeBugReport

#77615 opened 8 months ago by atzoum

adds unnecessary import for argument typeBugReportNeedsFix

#77610 opened 8 months ago by ddddddO

OOB panic in stringscut modernizer

#77595 opened 8 months ago by ramunas-cvirka

change -diff to exit 1 if diffs existFixPendingGoCommandToolProposal

#77583 opened 8 months ago by Rican7

stringscut does not fully recognize variable definition reuseBugReport

#77566 opened 8 months ago by creachadair

x/tools/go/analysis/passes/modernize: slicescontains hoists needle expression, changing side effect countBugReportNeedsFixTools

#77564 opened 8 months ago by findleyr

stringscut: OOB panic in indexArgValid analyzing "buf.Bytes()" call [1.26 backport]CherryPickApprovedTools

#77529 opened 8 months ago by gopherbot

stringscut: OOB panic in indexArgValid analyzing "buf.Bytes()" callBugReportTools

#77208 opened 9 months ago by mymmrac

bad rangeint rewritingBugReportTools

#77034 opened 9 months ago by zigo101

stringsbuilder breaks code when combining two `strings.Builder`sBugReportNeedsFixTools

#76983 opened 10 months ago by csilvers

remove all functionalityProposalProposal-AcceptedToolProposal

#73605 opened 1 year ago by adonovan

invalid -go=go1.21.0 [1.23 backport] [1.22 backport]FrozenDueToAge

#68827 opened 2 years ago by gopherbot

invalid -go=go1.21.0 [1.23 backport]FrozenDueToAge

#68826 opened 2 years ago by gopherbot

fails to run on modules whose go directive value is in "1.n.m" format introduced in Go 1.21.0 [1.22 backport]CherryPickApprovedFrozenDueToAge

#68825 opened 2 years ago by gopherbot

invalid -go=go1.21.0 [1.21 backport]FrozenDueToAge

#68824 opened 2 years ago by gopherbot

fails to run on modules whose go directive value is in "1.n.m" format introduced in Go 1.21.0FixPendingFrozenDueToAgeNeedsFix

#62584 opened 3 years ago by alexbozhenko

buildtag fix only kicks in with go.mod containing "go 1.18" or laterFrozenDueToAge

#52011 opened 4 years ago by gopherbot

update for genericsFrozenDueToAgeNeedsInvestigationrelease-blocker

#48978 opened 5 years ago by findleyr

allow third party packages to migrate using go fixFrozenDueToAgeProposal

#40162 opened 6 years ago by lu4p

apply suggested replacements for Deprecated functionsFrozenDueToAgeProposal

#38864 opened 6 years ago by CAFxX

incorrect loop variable aliasing in TestRewriteFrozenDueToAgeNeedsFixTesting

#35632 opened 7 years ago by mewmew

automate migrations for simple deprecationsFeatureRequestFrozenDueToAgeNeedsFixProposalProposal-Accepted

#32816 opened 7 years ago by bcmills

115

"go tool fix -r cftype" panic: ast.Expr is *ast.ArrayType, not *ast.SelectorExpr FrozenDueToAgeNeedsInvestigation

#23762 opened 8 years ago by pquerna

incomplete "go tool fix -r cftype" suggestionsFrozenDueToAgeNeedsInvestigation

#23091 opened 8 years ago by kevinburke

lots of unused codeFrozenDueToAgeNeedsFix

#18568 opened 9 years ago by shawnps

fix documentation issuesFrozenDueToAge

#8314 opened 12 years ago by gopherbot

simplify composite literals during fixFrozenDueToAge

#4505 opened 14 years ago by rsc

need fix for printer.ConfigFrozenDueToAge

#4499 opened 14 years ago by rsc

doesn't build into pkg/tool/<arch>/fixDocumentationFrozenDueToAge

#3049 opened 14 years ago by patrickmn

camlistore file fails to parse in go fixFrozenDueToAge

#2898 opened 14 years ago by bradfitz